Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: unsubscribe service #38

Merged
merged 1 commit into from
Oct 20, 2022
Merged

feat: unsubscribe service #38

merged 1 commit into from
Oct 20, 2022

Conversation

onewe
Copy link
Collaborator

@onewe onewe commented Oct 20, 2022

  • use Vec instead of HashSet
  • ignore some tests

relate: #2

@onewe
feat: unsubscribe service
7c9118d 
- use Vec instead of HashSet
- ignore some tests
@onewe onewe requested a review from CherishCai October 20, 2022 15:40
CherishCai
CherishCai reviewed Oct 20, 2022
View reviewed changes
src/common/event_bus/mod.rs
}

fn index_of_subscriber(
&self,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

index_of_subscriber 不需要 &self

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

的确不需要

@CherishCai CherishCai merged commit 6fb800e into nacos-group:main Oct 20, 2022
@onewe onewe deleted the issues/2-12 branch October 20, 2022 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CherishCai CherishCai CherishCai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@onewe @CherishCai